Correct typo in docs on acquisition functions #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hrovatin
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
AdrianSosic
approved these changes
Dec 5, 2024
AVHopp
requested changes
Dec 9, 2024
Scienfitz
approved these changes
Dec 11, 2024
AVHopp
approved these changes
Dec 11, 2024
Scienfitz
force-pushed
the
fix/docs_acq_typo
branch
from
612753b to
ae1174c
Compare
|
fyi I
|
Thank you. I tried to do rebase as it was needed due to changelog, but it seems I messed it up? @AVHopp the failing test is due to scikit fingerprints right? |
|
@Hrovatin , yes it seems like the tests still fail due to the fingerprints error. We could merge the corresponding PR first, then we should be able t verify this. |
Scienfitz
force-pushed
the
fix/docs_acq_typo
branch
from
ae1174c to
91e3e92
Compare
|
@Hrovatin please analyze what happened with the rebase so it doesnt happen again, seems to me maybe it was maybe rebased onto the wrong branch or so. In any case, be sure to have a backup branch before you do the rebase and let us know if you have any questions / uncertainty around rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small typo.